Add support for suppressing project events #22590
Conversation
|
VS appears to have begun to receive these events as of #19864. |
src/server/server.ts
Outdated
| @@ -535,6 +535,7 @@ namespace ts.server { | |||
| hrtime: process.hrtime, | |||
| logger, | |||
| canUseEvents, | |||
| suppressProjectEvents, | |||
There was a problem hiding this comment.
Feels like this should be flags that indicates event to suppress given that this does not suppress ProjectInfoTelemetryEvent which is project event
There was a problem hiding this comment.
In the interest of keeping the name intelligible, I decided not to incorporate that. They also don't seem conceptually related to projects.
There was a problem hiding this comment.
then may be rename it to onlyTelemetryEvent or something as such?
There was a problem hiding this comment.
It's not only telemetry. We also want TypingsInstaller events.
There was a problem hiding this comment.
We could call it suppressDiagnosticEvents, but then I'd feel obliged to let ProjectsUpdatedInBackgroundEvent through (which is fine, it just requires a different implementation).
There was a problem hiding this comment.
Changed to suppressDiagnosticEvents.
|
Note that only versions of VS patched to pass this additional flag will benefit from the change. |
|
Please add test to verify this functionality |
|
@sheetalkamat Better? |
|
Apparently, it is unwise to use GH's merge tool. I'll redo it locally. |
VS doesn't consume (e.g.) `syntaxDiag` events, so there's no reason to do the work to compute their payloads.
VS doesn't consume (e.g.)
syntaxDiagevents, so there's no reason to do the work to compute their payloads.